-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for nested files #4754
Conversation
@nicholascioli, please consider creating a changeset entry in |
CI performance tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except commit list containing unrelated commits 👍
resolves #4709 This commit adds some more integration tests for file uploads that test whether files nested in structures still work as expected.
e0e9c4c
to
a76eaf5
Compare
I've updated the commit list to just include my changes, but tests might fail now due to the blocking issue. Let me know if it looks good! |
Some tests were missing to ensure that files nested within other GraphQL types still resolved correctly, so this commit addresses that.
This change has been rebased off of #4726 since some tests fail when the output gets blocked.
Fixes #4709
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩